On 08/05/2014 04:33 PM, Varka Bhadram wrote:
On Tuesday 05 August 2014 08:01 PM, Brian Austin wrote:
On Mon, 4 Aug 2014, Varka Bhadram wrote:
On 08/05/2014 01:41 AM, Brian Austin wrote:
+#include <linux/module.h> +#include <linux/moduleparam.h> +#include <linux/version.h> +#include <linux/kernel.h> +#include <linux/init.h> +#include <linux/delay.h> +#include <linux/i2c.h> +#include <linux/gpio.h> +#include <linux/regmap.h> +#include <linux/slab.h> +#include <linux/platform_device.h> +#include <linux/regulator/consumer.h> +#include <linux/gpio/consumer.h> +#include <linux/of_device.h> +#include <linux/slab.h> +#include <sound/core.h> +#include <sound/pcm.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> +#include <sound/soc-dapm.h> +#include <sound/initval.h> +#include <sound/tlv.h> +#include <dt-bindings/sound/cs35l32.h>
+#include "cs35l32.h"
includes in alphabetical order...
I don't think that applies to included files outside of standard include directories does it?
+{
- struct snd_soc_codec *codec = dai->codec;
- return snd_soc_update_bits(codec, CS35L32_PWRCTL2,
CS35L32_SDOUT_3ST, tristate << 3);return snd_soc_update_bits(codec, CS35L32_PWRCTL2, CS35L32_SDOUT_3ST, tristate << 3);
If that is a style issue for submission checkpatch should warn on this correct?
should match open parenthesis's...
devm_kzalloc(&i2c_client->dev, sizeof(struct cs35l32_platform_data), GFP_KERNEL);
checkpatch?
checkpatch should generate warning for this...
Only in --subjective mode. Which is what this is, highly subjective. Some people prefer alignment to opening bracket, some people prefer 1 tab indention. Both has its advantages and disadvantages and both is usually fine as long as it stays consistent within the file.