Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

On Tue, 1 Aug 2023 12:22:39 +0200 Andrew Lunn andrew@lunn.ch wrote:

...

+static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset) +{

• int val;
• regmap_read(pef2256->regmap, offset, &val);
• return val;

+}

+static inline void pef2256_write8(struct pef2256 *pef2256, int offset, u8 val) +{

• regmap_write(pef2256->regmap, offset, val);

+}

More cases of inline functions in .C files. Please let the compiler decide.

Will be changed.

...

+static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr) +{

• dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr);

+}

Should this be rate limited? It is going to be very noise if it gets called once per frame time.

This function should not be called. It is wired on some interrupts and these interrupts should not be triggered. It they fired, something was wrong.

I would prefer to keep this dev_warn() to keep the user informed about the problem.

Regards, Hervé