On Tue, 27 Nov 2018 09:44:18 +0100, Pavel Machek wrote:
Hi!
this is patch series I've hacked after useful conversation with Pavel. Basically this adds a new LED trigger audio-mute and audio-micmute, and convert the HD-audio driver and the platform drivers to use the LED trigger instead of the ugly direct dynamic symbol binding.
Thanks a lot for doing this!
The latest version of patches are found in topic/leds-trigger branch in my sound git tree. git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
As these are cross-tree patches, the branch above is based cleanly on v4.20-rc3, so that it can be merged well to multiple trees.
Once after getting the ACK's, I'll add tags and fixate for merges.
This patch series don't include huawei-wmi stuff; so Huawei patches need rework. I already have some piece of changes for huawei-wmi, so please ping me if needed.
I checked briefly on my Dell laptop, and a Thinkpad model. Wider tests are appreciated, of course.
Looks good... except one detail: you have "tpacpi::micmute" and "dell::micmute". I know it follows "tradition", but we are trying to fix that at the moment. Laptop micmute button is a laptop micmute button, and userspace should not need to know what prefix to use depending on vendor.
I'd suggest using "sys::micmute".
OK, replaced them, and also add explanation in the patch logs.
With that:
Acked-by: Pavel Machek pavel@ucw.cz
Added now to the series in topic/leds-trigger branch.
I'm going to resubmit v2 series tomorrow or later, then merge the branch to for-next branch.
Thanks!
Takashi