[...]
- reset-gpio: a GPIO spec for the reset pin. If specified, it will be
deasserted before communication to the codec starts.
- power-down-gpio: a GPIO spec for the power down pin. If specified,
it will be deasserted before communication to the codecstarts.
I think the property name should always be '...-gpios', even if it is just one. There is some code in the kernel that assumes this.
[...]
+static const unsigned int sta350_limiter_ac_attack_tlv[] = {
- TLV_DB_RANGE_HEAD(2),
- 0, 7, TLV_DB_SCALE_ITEM(-1200, 200, 0),
- 8, 16, TLV_DB_SCALE_ITEM(300, 100, 0),
+};
+static const unsigned int sta350_limiter_ac_release_tlv[] = {
- TLV_DB_RANGE_HEAD(5),
- 0, 0, TLV_DB_SCALE_ITEM(TLV_DB_GAIN_MUTE, 0, 0),
- 1, 1, TLV_DB_SCALE_ITEM(-2900, 0, 0),
- 2, 2, TLV_DB_SCALE_ITEM(-2000, 0, 0),
- 3, 8, TLV_DB_SCALE_ITEM(-1400, 200, 0),
- 8, 16, TLV_DB_SCALE_ITEM(-700, 100, 0),
+};
+static const unsigned int sta350_limiter_drc_attack_tlv[] = {
- TLV_DB_RANGE_HEAD(3),
- 0, 7, TLV_DB_SCALE_ITEM(-3100, 200, 0),
- 8, 13, TLV_DB_SCALE_ITEM(-1600, 100, 0),
- 14, 16, TLV_DB_SCALE_ITEM(-1000, 300, 0),
+};
+static const unsigned int sta350_limiter_drc_release_tlv[] = {
- TLV_DB_RANGE_HEAD(5),
- 0, 0, TLV_DB_SCALE_ITEM(TLV_DB_GAIN_MUTE, 0, 0),
- 1, 2, TLV_DB_SCALE_ITEM(-3800, 200, 0),
- 3, 4, TLV_DB_SCALE_ITEM(-3300, 200, 0),
- 5, 12, TLV_DB_SCALE_ITEM(-3000, 200, 0),
- 13, 16, TLV_DB_SCALE_ITEM(-1500, 300, 0),
+};
Those TLVs above should use DECLARE_TLV_DB_RANGE(). The macro automatically sets the number specified in the TLV_DB_RANGE_HEAD is equal to the number of items, hence leaves less room for errors.
E.g.
static DECLARE_TLV_DB_RANGE(sta350_limiter_ac_attack_tlv, 0, 7, TLV_DB_SCALE_ITEM(-1200, 200, 0), 8, 16, TLV_DB_SCALE_ITEM(300, 100, 0), ); [...]
+static int sta350_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)+{
- struct sta350_priv *sta350;
- int ret, i;
- sta350 = devm_kzalloc(&i2c->dev, sizeof(struct sta350_priv),
GFP_KERNEL);- if (!sta350)
return -ENOMEM;- sta350->pdata = dev_get_platdata(&i2c->dev);
- sta350->gpio_nreset = -EINVAL;
- sta350->gpio_power_down = -EINVAL;
- mutex_init(&sta350->coeff_lock);
+#ifdef CONFIG_OF
- ret = sta350_probe_dt(&i2c->dev, sta350);
You still need to check if i2c->dev.of_node is actually set.
- if (ret < 0)
return ret;+#endif
- /* GPIOs */
- if (gpio_is_valid(sta350->gpio_nreset)) {
ret = devm_gpio_request_one(&i2c->dev, sta350->gpio_nreset,GPIOF_OUT_INIT_HIGH,"ST350 Reset");
New code should use the GPIO descriptor API. See http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/...
if (ret < 0)return ret;- }