On Mon, Feb 23, 2009 at 06:15:18PM +0200, Takashi Iwai wrote:
At Mon, 23 Feb 2009 14:00:43 +0100, I wrote:
- if reconfig while playing audio, it will trigger a panic:
Ah, that's bad. I know this can be a problem (and thus is marked as EXPERIMENTAL :)
We need some mutex and/or flag to disable the reconfig during the critical operation.
It won't be a trivial work. The reset/rebuild is a long and complex process. For the moment I'd suggest to simply fail reconfig if there are active streams,
Yep, that's what I thought of, too.
so as to let this useful feature go upstream ASAP.
I'll merge the branch soon later.
FYI, now the branch is merged to master. The dynamic pincfg feature is available on alsa-driver snapshot, too.
Also, I added the check of opened streams before doing clear/reconfig work so that the kernel panic won't happen so easily.
That's great, thank you!
Regards, Fengguang