On Mon, Sep 08, 2008 at 01:06:12PM +0400, Dmitry Baryshkov wrote:
Here's a version of the third patch in the series without all the cpu_is_pxa3xx())'s around the pxa_gpio_mode's? Also, there was a build error when just building the sound/arm pxa2xx-ac97.
If there's a build error introduced by the earlier patch it ought to be fixed there rather than in a subsequent patch?
-#ifdef CONFIG_PXA3xx -#define GCR_CLKBPB (1 << 31) /* Internal clock enable */ -#endif +#define GCR_CLKBPB (1 << 31) /* Internal clock enable, PXA3XX only */
At least this hunk needs to at least get acked by rmk, and would probably need to go via the ARM tree.
- if (!cpu_is_pxa3xx()) {
pxa_gpio_mode(GPIO31_SYNC_AC97_MD);pxa_gpio_mode(GPIO30_SDATA_OUT_AC97_MD);pxa_gpio_mode(GPIO28_BITCLK_AC97_MD);pxa_gpio_mode(GPIO29_SDATA_IN_AC97_MD);- }
I'd rather do this by explicitly identifying the PXA2xx CPUs (on the basis that Marvell are producing new PXA variants but the set of PXA2xx CPUs should be fixed now).
--- a/sound/soc/pxa/pxa2xx-i2s.c +++ b/sound/soc/pxa/pxa2xx-i2s.c
This should be split into a separate patch - it's not directly related to the other changes except in terms of the overall goal and covers a different driver. It's also not mentioned in the patch description.