On Fri, Apr 24, 2009 at 02:54:40PM +0100, Mark Brown wrote:
I'll send a new patch for that, providing this feature in a slightly more complex fashion. However, I don't want to remove the other function. If the soc core decides to mute the codec, it should be able to do so.
It's not the core that needs it, it's the DAC that normally needs the core to mute it (modulo random floating signals that it might parse) - if cs4270 is happy without the mute then the core doesn't care if it's not there.
This codec has pins which are usually connected to some external logic that can switch off aplifiers and the like when the code is in its mute state. Which is a nice feature: once you stop the ALSA output, everything behind the codec in the analog section is put into a power saving mode and is magically revived once ALSA starts using it again. That's why I want to leave it in there, even if the codecs does not necessarily need it.
Daniel