On Tue, Apr 12, 2016 at 06:54:35AM +0100, Mark Brown wrote:
On Tue, Apr 12, 2016 at 07:43:59AM +0200, Takashi Iwai wrote:
But the problem is more complicated because you're changing drm stuff, too. This is usually managed in drm tree. So this cross over three different trees.
The DRM folks tend to leave this up to us, or at least review on any of these crossover patches has been extremely light.
Do we really need this? Even the direct reference is pretty much obvious. e.g. I see no big difference between two lines below: spk_alloc = drm_eld_get_spk_alloc(some_eld); spk_alloc = some_eld[DRM_ELD_SPAEKER];
That'd make things even easier of course.
Takashi/Mark, Thanks for the review. Agree, accomodating in the driver is easier and the inline function doesn't make much difference. I will accomodate the change in the driver itself.
Shall I repost the series with these changes, which can be reviewed further or wait for more review comments before reposting?
Regards, Subhransu
--