On Fri, 28 Feb 2020 at 17:12, Mark Brown broonie@kernel.org wrote:
On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote:
Don't confuse user with meaningless warning about the failure in getting resources and registering card in case of deferred probe.
if (ret) {
dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret);
if (ret != -EPROBE_DEFER)dev_err(&pdev->dev,"snd_soc_register_card() failed: %d\n", ret);This is completely removing the diagnostics so if things do get stuck the user will generally not have any hint as to what's going wrong - it's better with this sort of change to lower to dev_dbg() for deferral rather than completely removing the error message so the user has some ability to figure out what was missing. However in this case it's also the case that snd_soc_register_card() is fairly noisy.
This dev_dbg could be achieved with ftrace for probe() as well. I think it is quite common to skip all messages for deferred probes.
Best regards, Krzysztof