Hi Takashi,
On 22/08/16 12:47, Takashi Iwai wrote:
On Mon, 15 Aug 2016 21:54:49 +0200, Takashi Sakamoto wrote:
Hi,
On Aug 16 2016 01:37, Felipe F. Tonello wrote:
Small improvement to amidi, adding useful functionality.
changes from v4:
- simplified code
changes from v3:
- fixed a bug if memchr() returns NULL
changes from v2:
- only check of end of sysex (0xf7)
- use memchr() instead of direct loop approach
- fixed commit message
changes from v1:
- remove delay in between any MIDI message, only SysEx
- added patch to use getopt_long() arguments
Felipe F. Tonello (2): amidi: add delay option amidi: use GNU getopt_long() proper argument names
amidi/amidi.1 | 14 ++++++++++++++ amidi/amidi.c | 61 +++++++++++++++++++++++++++++++++++++++++++---------------- 2 files changed, 59 insertions(+), 16 deletions(-)
Please notice the other developers' work. Clemens already posted his patchset with similar improvements.
http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111737.html
And I reviewed and tested it. http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111745.html
It's not merged yet, because subsystem maintainer has a summer vacation. http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/111741.html
It's better for you to wait for merging or work based on Clemens' patchset, I think.
Yep, now Clemens' patches were merged to git tree. Please rebase and resubmit if anything is missing.
Ok.