Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller

Hi Rob, On Sun, 26 Feb 2023 11:48:33 -0600 Rob Herring robh@kernel.org wrote:

[...]

...

• '#size-cells':
• const: 0
• '#fsl,serial-cells':

#foo-cells is for when there are differing foo providers which need different number of cells. That's not the case here.

Ok, I will remove the #fsl,serial-cells property on the next iteration.

On the next series iteration, I will also remove the #fsl,chan-cells property present later on a patch related to the QMC binding. The #fsl,chan-cells needs to be removed exactly for the same reason.

...

• $ref: /schemas/types.yaml#/definitions/uint32
• const: 1
• description:

•  TSA consumers that use a phandle to TSA need to pass the serial identifier
  

•  with this phandle (defined in dt-bindings/soc/fsl,tsa.h).
  

•  For instance "fsl,tsa-serial = <&tsa FSL_CPM_TSA_SCC4>;".  
  

Thanks for the review. Hervé