Hi Takashi,
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Thursday, April 11, 2019 10:48 PM To: Yang, Libin libin.yang@intel.com Cc: alsa-devel@alsa-project.org; broonie@kernel.org; pierre- louis.bossart@linux.intel.com Subject: Re: [alsa-devel] [PATCH v3 01/12] ASoC: intel: boards: define some general functions for hdac_hdmi
On Thu, 11 Apr 2019 16:19:49 +0200, libin.yang@intel.com wrote:
+static int hdac_hdmi_add_device_link(struct device *consumer,
struct device *supplier,struct device_link **link)Missing inline?
But, before sending v4, please hold on.
I'm thinking whether we can do this rather in the component init of the hdac- hdmi codec driver. Can't we get the machine device somehow at the time of codec component init?
Or even if it's too early, there is also late_probe callback that is called after binding all... If we can manage to create a link from the codec side, we need to change only one place, instead of scattering allover the tree.
We just can call it in component driver probe(). It will not too early. After the machine registers the soc card, it will call the component->driver->probe(). So it is safe we call device_link_add() in component driver probe().
I will submit a new patch soon.
Regards, Libin
thanks,
Takashi