9 Sep
                
                    2014
                
            
            
                9 Sep
                
                '14
                
            
            
            
        
    
                10:37 p.m.
            
        On 09/09/2014 03:27 PM, Nicolin Chen wrote:
I guess Mark's comment is merely against the check for clk validation because if talking about clk validation, we should check IS_ERR(clk) rather than check !=NULL directly.
Ah, that makes sense now.
However, my approach doesn't need any check. The open() or pm_resume() can just call clk_prepare_enable() directly. The __clk_enable() will then handle the 'clk == NULL' case:
Yes, I was thinking the same thing.