At Fri, 13 Jul 2012 08:08:26 +0200, Daniel Mack wrote:
On 13.07.2012 07:58, Takashi Iwai wrote:
At Thu, 12 Jul 2012 15:19:47 +0200, Daniel Mack wrote:
The rework of the snd-usb endpoint logic moved the calls to snd_usb_set_interface() into the snd_usb_endpoint implemenation. This changed the order in which these calls are issued to the device, and thereby caused regressions for some webcams.
Fix this by moving the calls back to pcm.c for now to make it work again and use snd_usb_endpoint_activate() to really tear down all remaining URBs in the flight, consequently fixing another regression caused by USB packets on the wire after altsetting 0 has been selected.
Signed-off-by: Daniel Mack zonque@gmail.com Reported-and-tested-by: Philipp Dreimann philipp@dreimann.net Reported-by: Joseph Salisbury joseph.salisbury@canonical.com
Looks like the patch contains lots of coding-style issues. Could you fix what checkpatch.pl compains and resubmit?
Oops, sorry. Was working on a different machine for this, hence I didn't notice.
Applied now. Thanks.
Takashi