Hi
On Mon, Oct 6, 2014 at 8:44 PM, Stephen Warren swarren@nvidia.com wrote:
On 09/30/2014 02:52 PM, Anatol Pomozov wrote:
The driver will support Ryu board
diff --git
a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.txt
+- nvidia,i2s-controller : The phandle of the Tegra I2S controller that's
- connected to the CODEC.
+- nvidia,audio-codec : The phandle of the RT5677 audio codec. This
binding
- assumes that AIF1 on the CODEC is connected to Tegra.
+- nvidia,speaker-codec: The phandle of the SSM4567 amplifier. This
binding
- assumes that AIF2 on the audio CODEC is connected to this speaker
amplifier.
Does the CODEC only output audio on an I2S link, or does it also have analog outputs?
Tegra Ryu board uses LOUT1/LOUT2 for headphones and I2S2 for speaker amp.
As Mark mentioned, this binding deviates from the other generic audio bindings for Tegra in that the others all have CODEC analog outputs connected to speakers/headphones, whereas this binding requires an extra I2S based component, which doesn't seem very generic.
+sound {
compatible = "nvidia,tegra-audio-rt5677-ryu","nvidia,tegra-audio-rt5677";nvidia,model = "NVIDIA Tegra Ryu";nvidia,audio-routing =// rt5677 codecLet's use /* */
diff --git a/sound/soc/tegra/tegra_rt5677.c
b/sound/soc/tegra/tegra_rt5677.c
+static struct snd_soc_pcm_stream tegra_rt5677_spk_params = {
.formats = SNDRV_PCM_FMTBIT_S16_LE,.channels_min = 2,.channels_max = 2,+};
...
+static int tegra_rt5677_asoc_hw_params(struct snd_pcm_substream
*substream,
struct snd_pcm_hw_params *params)...
/* both dai interfaces use the same bit clock,* set rate for both interfaces the same, otherwise driver mightnot
* be able to configure clock divider.*/tegra_rt5677_spk_params.rate_min = srate;tegra_rt5677_spk_params.rate_max = srate;This feels a bit odd. Shouldn't hw_params simply call some function on the appropriate DAI to configure it directly for the required sample rate?
That actually was my question above. Is there any better way to do the same? I did not find any function that does it.
+static struct snd_soc_dai_link tegra_rt5677_dai[] = { +{
The array entries should be indented 1 level.
+static int tegra_rt5677_remove(struct platform_device *pdev) +{
struct snd_soc_card *card = platform_get_drvdata(pdev);struct tegra_rt5677 *machine = snd_soc_card_get_drvdata(card);snd_soc_jack_free_gpios(&tegra_rt5677_hp_jack, 1,&tegra_rt5677_hp_jack_gpio);That needs to be part of the struct snd_soc_card's .remove function, not the struct platform_driver's .remove function. See the git history of other Tegra reasons for details of the crash this prevents.
Thanks for the pointer, the change you mentioned is fb6b8e71448aef. Fixed it locally.
I will send updated change in a few days in addition to other cosmetic changes.