Re: [alsa-devel] [PATCH 4/6] ASoC: wm5110: Add support for audio trace firmware

On Fri, Jan 29, 2016 at 12:34:22AM +0100, Mark Brown wrote:

On Thu, Jan 21, 2016 at 05:53:00PM +0000, Charles Keepax wrote:

...

@@ -2163,6 +2187,8 @@ static int wm5110_open(struct snd_compr_stream *stream)

if (strcmp(rtd->codec_dai->name, "wm5110-dsp-voicectrl") == 0) { n_adsp = 2;

• } else if (strcmp(rtd->codec_dai->name, "wm5110-dsp-trace") == 0) {

• n_adsp = 0;
  

  } else { dev_err(arizona->dev, "No suitable compressed stream for DAI '%s'\n",

I'm a bit unclear on how exactly we're ensuring that the relevant firmware is loaded?

So this code is basically just working out which DSP core we should be opening (at the moment this is fixed a DAI coresponds to a particular DSP core). At the bottom of the function we call wm_adsp_compr_open which will check that the firmware supports compressed operation in the correct direction and will lock out changes of firmware until compr_free is called.

Thanks, Charles