Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master_ops and IO transfer support

struct sdw_cdns { struct device *dev; struct sdw_bus bus; unsigned int instance;

• u32 response_buf[0x80];

last nit-pick: use a #define for the size. Also are you sure about the value? I vaguely recall that the FIFO was 32-deep, you are confusing bytes and words here?

• struct completion tx_complete;

• struct sdw_defer *defer;

• void __iomem *registers;

  bool link_up;

• unsigned int msg_count; };