Re: [PATCH v3 2/3] ASoC: Intel: sof_es8336: support a separate gpio to control headphone

-static const struct acpi_gpio_params speakers_enable_gpio0 = { 0, 0, true }; +static const struct acpi_gpio_params enable_gpio0 = { 0, 0, true }; +static const struct acpi_gpio_params enable_gpio1 = { 1, 0, true };

• static const struct acpi_gpio_mapping acpi_speakers_enable_gpio0[] = {

• { "speakers-enable-gpios", &speakers_enable_gpio0, 1 },

• { "speakers-enable-gpios", &enable_gpio0, 1 }, { } };

-static const struct acpi_gpio_params speakers_enable_gpio1 = { 1, 0, true }; static const struct acpi_gpio_mapping acpi_speakers_enable_gpio1[] = {

• { "speakers-enable-gpios", &speakers_enable_gpio1, 1 },

• { "speakers-enable-gpios", &enable_gpio1, 1 },

+};

nit-pick: these changes could be applied to the previous patch.

the rest of the code looks fine, thanks Mauro!