On 1/20/2021 6:29 PM, Mark Brown wrote:
On Wed, Jan 20, 2021 at 04:28:43PM +0100, Amadeusz Sławiński wrote:
As described in preceding patch, waiting with DAI removal until device is being unregistered can lead to working on freed memory, hence having
There is a potential for misuse with essentially all devm functions - why is this one so special?
Hm... right, I blinded myself thinking too much about specific use case where it was used in topology. As topology is used with drivers split into multiple modules where it caused problem. It should work fine if someone writes monolithic module and needs to register DAI. I guess we can skip this patch then.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
DAIs managed by resource managed memory is a bad idea, revert commit creating devm_ API for this, so no one makes a mistake of using it.
This reverts commit 0fae253af563cf5d1f5dc651d520c3eafd74f183.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.