Re: [alsa-devel] [PATCH] ASoC: Return -1 instead of -EINVAL to ensure consistency

On Tue, Sep 21, 2010 at 05:04:07PM +0100, Dimitris Papastamos wrote:

The code can't really cope with I/O errors, so it would be better to be consistent throughout all cache functions and return -1 instead of -EINVAL.

The return value of snd_soc_read(...) is mostly checked in the probe function and nowhere else.

Applied, thanks.