-----Original Message----- From: Alsa-devel alsa-devel-bounces@alsa-project.org On Behalf Of Amadeusz Slawinski Sent: Thursday, May 7, 2020 9:34 PM To: Rojewski, Cezary cezary.rojewski@intel.com; Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com; Liam Girdwood lgirdwood@gmail.com; Jie Yang yang.jie@linux.intel.com; Mark Brown broonie@kernel.org; Takashi Iwai tiwai@suse.com Cc: alsa-devel@alsa-project.org; Amadeusz Sławiński amadeuszx.slawinski@linux.intel.com Subject: [PATCH 1/2] ASoC: Intel: baytrail: Fix register access
Baytrail has 64 bit registers, so we should use *read64* to read from it and then use proper mask values to check status.
Signed-off-by: Amadeusz Sławiński amadeuszx.slawinski@linux.intel.com
Tested-by: Brent Lu brent.lu@intel.com
Regards, Brent
sound/soc/intel/baytrail/sst-baytrail-ipc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/baytrail/sst-baytrail-ipc.c b/sound/soc/intel/baytrail/sst-baytrail-ipc.c index 74274bd38f7a..34746fd871b0 100644 --- a/sound/soc/intel/baytrail/sst-baytrail-ipc.c +++ b/sound/soc/intel/baytrail/sst-baytrail-ipc.c @@ -666,8 +666,8 @@ static bool byt_is_dsp_busy(struct sst_dsp *dsp) { u64 ipcx;
- ipcx = sst_dsp_shim_read_unlocked(dsp, SST_IPCX);
- return (ipcx & (SST_IPCX_BUSY | SST_IPCX_DONE));
- ipcx = sst_dsp_shim_read64_unlocked(dsp, SST_IPCX);
- return (ipcx & (SST_BYT_IPCX_BUSY | SST_BYT_IPCX_DONE));
}
int sst_byt_dsp_init(struct device *dev, struct sst_pdata *pdata)
2.17.1