On 2021/10/27 下午 10:05, Pierre-Louis Bossart wrote:
On 10/26/21 9:51 PM, David Lin wrote:
A feature for disabling jack detection support.
Co-developed-by: Mac Chiang mac.chiang@intel.com Signed-off-by: Mac Chiang mac.chiang@intel.com Signed-off-by: David Lin CTLIN0@nuvoton.com
sound/soc/codecs/nau8825.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index c845f19b7c41..a356f26735bd 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -1434,6 +1434,13 @@ int nau8825_enable_jack_detect(struct snd_soc_component *component,
nau8825->jack = jack;
- if (!nau8825->jack) {
regmap_update_bits(regmap, NAU8825_REG_HSD_CTRL,NAU8825_HSD_AUTO_MODE | NAU8825_SPKR_DWN1R |NAU8825_SPKR_DWN1L, 0);return 0;- }
oh, so you've addressed my comment from the first patch but it might be clearer to follow the flow from other codec drivers and test the jack argument at a higher level, then you have an enable/disable parameter.
Yes, I understand your thinking. You consider more clearly logic and readable for overall code.
Your suggestion make me with one target follow. I can do more plan for next.
/* Ground HP Outputs[1:0], needed for headset auto detection * Enable Automatic Mic/Gnd switching reading on insert interrupt[6] */
________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.