On 6/29/2020 6:35 AM, Kuninori Morimoto wrote:
External email: Use caution opening links or attachments
Hi Sameer
CPU/Codec in DPCM DAI links are connected as CPU<->Dummy and Dummy<->Codec. Though mostly CPU won't use/require 'mclk-fs' property, looping over 'np' (current child node in a DAI link) can help in cases where multiple Codecs are defined. This further helps to get rid of 'codec' argument from simple_dai_link_of_dpcm() function, which gets called for DPCM links.
Signed-off-by: Sameer Pujar spujar@nvidia.com
(snip)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 39cdc71..02d6295 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -107,7 +107,9 @@ static void simple_parse_mclk_fs(struct device_node *top, snprintf(prop, sizeof(prop), "%smclk-fs", prefix); of_property_read_u32(node, prop, &props->mclk_fs); of_property_read_u32(cpu, prop, &props->mclk_fs);
of_property_read_u32(codec, prop, &props->mclk_fs);
if (cpu != codec)
of_property_read_u32(codec, prop, &props->mclk_fs);
Maybe we want to have "cpu" in simple_dai_link_of_dpcm() side without using magical code in simple_parse_mclk_fs() side ?
Are you suggesting if we should simplify simple_parse_mclk_fs() by either passing 'cpu' or 'codec'?
Thank you for your help !!
Best regards
Kuninori Morimoto