Dne 13.3.2012 10:58, Takashi Iwai napsal(a):
.....
I'd suggest to move the common parts of the three ice1712 drivers into separate files. You could make the interface of those files similar to ASoC codec drivers to make later porting easier.
How about a solution similar to AKM codecs in i2c/other? Several ice1724 cards make use of those modules, easy to support and re-use. IMO cleaner approach than duplicating ICE1724 to the ASoC framework.
ASoC would be rather a "cleaner" approach, but moving the common code into i2c/other would be a "safer" approach. It can be done without shifting the whole infrastructure of ice17xx and oxygen drivers, indeed.
That is very true. I am afraid we do not have all the cards physically available to test a major overhaul of ice17xx.
Pavel.