Re: [alsa-devel] [patch 1/2] ASoC: max9867: signedness bug in max9867_dai_hw_params()

2016-02-25 15:48 GMT+08:00 Dan Carpenter dan.carpenter@oracle.com:

"value" needs to be signed for the error handling to work.

Fixes: 805d132dcbbd ('ASoC: Add max9867 codec driver') Signed-off-by: Dan Carpenter dan.carpenter@oracle.com

diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index ab7a94d..4fb6fc7 100755 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -180,7 +180,8 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_codec *codec = dai->codec; struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec);

•   unsigned int ni_h, ni_l, value;
  

•   unsigned int ni_h, ni_l;
  

•   int value;
  

Already fixed by http://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=topi...