14 May
2020
14 May
'20
12:16 p.m.
On Thu, May 14, 2020 at 03:31:52PM +0800, Tzung-Bi Shih wrote:
On Wed, May 13, 2020 at 3:47 PM Steve Lee steves.lee.maxim@gmail.com wrote:
+++ b/sound/soc/codecs/max98390.c @@ -0,0 +1,1030 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/*
- max98390.c -- MAX98390 ALSA Soc Audio driver
- Copyright (C) 2020 Maxim Integrated Products
- */
My previous comments on Gerrit may confuse you. Please use C++ style comments (i.e. // for all lines) here as the maintainer asked.
Mark, may I ask why we need to do so? Is it also applicable to header files?
It's to make things look neater - having the two comments immediately next to each other doesn't look intentional. Header files require a /* */ comment for the SPDX stuff so should do that.