On 12/19/2012 04:17 PM, Lucas Stach wrote:
This adds the DT bindings and a default entry for the Tegra 2x AC97 host controller.
Everything here except the .dtsi file should be part of the previous patch.
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.txt
+- nvidia,codec-sync-gpio : The Tegra GPIO controller's phandle and the number
- of the GPIO corresponding with the AC97 DAP _FS line
Hmm, for I2S at least, FS (frame sync I assume) definitely is something that the audio controller itself drives. Are you absolutely sure that this should be represented as a GPIO here?
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
- tegra_ac97: ac97@70002000 {
There's only 1 node named ac97, so you can leave out the unit address since it's not required to generate a unique node name. In other words just "ac97".