29 Jul
2015
29 Jul
'15
5:56 p.m.
On Wed, Jul 29, 2015 at 10:20:29PM +0530, Vinod Koul wrote:
On Wed, Jul 29, 2015 at 01:33:23PM +0100, Mark Brown wrote:
+static int skl_alloc_queue(struct skl_module_pin *mpin,
struct skl_module_inst_id id, int max)+{
- struct skl_module_pin m_pin = skl_get_queue(mpin, id, max);
- if (m_pin.pin_index < 0)
return -EINVAL;- if (m_pin.is_dynamic) {
m_pin.in_use = true;m_pin.id.module_id = id.module_id;m_pin.id.instance_id = id.instance_id;- }
Double indentation here. It's really unclear to me why a static pin doesn't need to get merked as in use?
Oops, will fix
In static pin case, the pins come from topology binary where these are fixed for a configuration, so don't need to be allocated thus marked and hence freed.
But isn't this also protecting against attempts to use the resource multiple times within the configuration (or shouldn't we be doing that)?
Please bear in mind that this stuff has basically zero documentation or explanation so I'm kind of guessing as to what this is supposed to do.