On Fri, Jul 14, 2023 at 11:24:50AM +0800, Zhu Ning wrote:
The old register naming method is confusing. The reg 0x57 decides the default headset hardware connection type, and the reg 0xfb is the headset detection status register, which changes during headset insertion. Change the name to ES8326_HPDET_TYPE and ES8326_HPDET_STA.
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/codecs/es8326.c: In function ‘es8326_resume’: /build/stage/linux/sound/soc/codecs/es8326.c:659:38: error: ‘ES8326_HP_DET’ undeclared (first use in this function); did you mean ‘ES8326_HP_OFF’? 659 | regmap_write(es8326->regmap, ES8326_HP_DET, | ^~~~~~~~~~~~~ | ES8326_HP_OFF