Re: [alsa-devel] [PATCH 1/4] extend ad1938 codec driver to ad193x supporting ad1936/7/8/9

On Thu, 2010-03-18 at 16:16 +0800, Barry Song wrote:

This patch extends ad1938 codec driver to support ad1936/7/8/9, ad1936/7 use i2c bus, ad1938/9 use spi bus. The driver is splitted into three: ad193x.h and ad193x.c: common codec driver ad193x-spi.c: ad193x codec spi driver ad193x-i2c.c: ad193x codec i2c driver

Is the new common driver code the same as the original driver minus any I2C/SPI changes ? It's difficult to see if anything else has been changed.

Btw, have a look at wm8731.c. This driver supports both I2C and SPI and is less churn than splitting out the code into three files.

Thanks

Liam