Re: [alsa-devel] [PATCH 5/5] sound/aoa: Add kmalloc NULL tests

On Thu, 2009-07-30 at 16:11 +0200, Julia Lawall wrote:

From: Julia Lawall julia@diku.dk

Check that the result of kzalloc is not NULL before a dereference.

irq_client = kzalloc(sizeof(struct pmf_irq_client),
		     GFP_KERNEL);

• if (!irq_client) {
  

• 	err = -ENOMEM;
  

• 	printk(KERN_ERR "snd-aoa: gpio layer failed to"
  

• 		" register %s irq (%d)\n", name, err);
  

• 	goto out_unlock;
  

• }
  

Looks good, thanks, but I'd really drop the printk if only to not have the string there, that doesn't really seem interesting.

johannes