26 Jun
2023
26 Jun
'23
3:53 a.m.
-----Original Message----- From: Mark Brown broonie@kernel.org Sent: Wednesday, June 21, 2023 8:41 PM To: Jack Yu jack.yu@realtek.com Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de; Flove(HsinFu) flove@realtek.com; Oder Chiou oder_chiou@realtek.com; Shuming [范書銘] shumingf@realtek.com; Derek [方德義] derek.fang@realtek.com Subject: Re: [PATCH] ASoC: rt722-sdca: Remove redundant sdca mask
On Wed, Jun 21, 2023 at 04:07:50PM +0800, Jack Yu wrote:
Remove redundant sdca mask for clear code.
sdw_write_no_pm(rt722->slave, SDW_SCP_SDCA_INTMASK1,
SDW_SCP_SDCA_INTMASK_SDCA_0 |SDW_SCP_SDCA_INTMASK_SDCA_6);
SDW_SCP_SDCA_INTMASK_SDCA_6); sdw_write_no_pm(rt722->slave, SDW_SCP_SDCA_INTMASK2, SDW_SCP_SDCA_INTMASK_SDCA_8);Why is this redundant?
Based on internal register settings, this bit won't be used in any use case, so I remove it for clear code.
------Please consider the environment before printing this e-mail.