On 03/16/2018 08:37 AM, Krzysztof Kozlowski wrote:
diff --git a/Documentation/devicetree/bindings/sound/samsung,odroid.txt b/Documentation/devicetree/bindings/sound/samsung,odroid.txt index f35a2694eb04..a50a0c6a354b 100644 --- a/Documentation/devicetree/bindings/sound/samsung,odroid.txt +++ b/Documentation/devicetree/bindings/sound/samsung,odroid.txt @@ -1,8 +1,10 @@ -Samsung Exynos Odroid XU3/XU4 audio complex with MAX98090 codec +Hardkernel Odroid X/X2/U3/XU3/XU4 audio complex with MAX98090 codec
Required properties:
- compatible - "hardkernel,odroid-xu3-audio" - for Odroid XU3 board,
- compatible - "hardkernel,odroid-u3-audio" - for Odroid U3 board,
"hardkernel,odroid-x-audio" - for Odroid X, Odroid X2 boards,"hardkernel,odroid-xu3-audio" - for Odroid XU3 board, "hardkernel,odroid-xu4-audio" - for Odroid XU4 boardThese are the same so I think they should not get separate compatibles. By definition [2] the compatible expresses the compatibility with family of devices. In this case - these belong to the same family.
The same applies to patch 5/5 (implementation of this).
Given that everything except XU4 is already obsoleted, are we going to use "hardkernel,odroid-xu3-audio" for Odroid X and Odroid U3?
We could also make it: "hardkernel,odroid-xu3-audio", "hardkernel,odroid-x-audio" - for Odroid X, Odroid X2 "hardkernel,odroid-xu3-audio", "hardkernel,odroid-u3-audio" - for Odroid U3
And in the driver wee would only have "hardkernel,odroid-xu3-audio", while dts would contain detailed compatible.