On Fri, Jan 09, 2015 at 12:45:31PM +0100, Jean-Francois Moine wrote:
On Fri, 9 Jan 2015 11:19:35 +0000 Russell King - ARM Linux linux@arm.linux.org.uk wrote:
Would it be more sensible to make SND_SOC_TDA998X depend on DRM_I2C_NXP_TDA998X instead, maybe with a 'default y' - which is a kinder way to have SND_SOC_TDA998X be enabled. If SND_SOC_TDA998X doesn't have a prompt, then it'll automatically enable itself too this way when all its dependencies are satisfied.
You are right, I will set back the way I had in the version 3:
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index b33b45d..747e387 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -352,6 +352,12 @@ config SND_SOC_STAC9766 config SND_SOC_TAS5086 tristate
+config SND_SOC_TDA998X
- tristate
- default y if DRM_I2C_NXP_TDA998X=y
- default m if DRM_I2C_NXP_TDA998X=m
An easier way to write this is:
config SND_SOC_TDA998X def_tristate y depends on DRM_I2C_NXP_TDA998X
That's because internally, Kconfig knows how to do ternary operations.