17 Aug
2015
17 Aug
'15
7:33 p.m.
On Mon, Aug 17, 2015 at 09:48:11AM +0200, Lars-Peter Clausen wrote:
Yes, I was. In my opinion this set_dai_fmt() implementation is useful to have as a mechanism to detect invalid configurations. E.g. if you don't implement the callback the CODEC will accept any setting while with he callback it will error out with the wrong configuration. Given that a I2S link typically at least somewhat works, even if you have the wrong setting, I think it makes sense to keep it to catch errors early on.
I agree that it's useful to catch such errors however I don't want to go to implementing basically empty functions if we don't have to - we should add the ability to specify capabilites in the DAI for the core to check instead.