On 11/23/21 11:06 AM, tanureal@opensource.cirrus.com wrote:
On 11/23/21 4:59 PM, Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
+#ifdef CONFIG_ACPI +static const struct acpi_device_id cs35l41_acpi_hda_match[] = { + {"CLSA0100", 0 },
I could be wrong but this doesn't look like a legit ACPI _HID?
Cirrus Logic can use 'CIR', "CLI", or 'CSC' PNP ID, or an PCI ID.
in the past you used
+#ifdef CONFIG_ACPI +static const struct acpi_device_id cs35l41_acpi_match[] = { + { "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */ + {}, +}; +MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match); +#endif
This ACPI _HID is already released, there is nothing I can do about it. Future devices will use 'CSC' PnP ID.
ok, add a comment then that you're adding support for an already-released value that's not compliant.