Re: [alsa-devel] [PATCH v2 08/13] OMAP2+: McBSP: hwmod adaptation for McBSP

Looks good, but...

On 01/31/2011 04:50 PM, ext Kishon Vijay Abraham I wrote:

Modify OMAP2+ McBSP to use omap hwmod framework APIs

Signed-off-by: Kishon Vijay Abraham I kishon@ti.com Signed-off-by: Charulatha V charu@ti.com Signed-off-by: Shubhrajyoti D shubhrajyoti@ti.com

---

arch/arm/mach-omap2/mcbsp.c | 685 +++---------------------------------------- 1 files changed, 43 insertions(+), 642 deletions(-)

...

• if (oh->class->rev == MCBSP_CONFIG_TYPE3) {

• if (id == 2)
  

• 	pdata->buffer_size = 0x500; /*FIFO size is 1024 + 256*/
  

• else
  

• 	pdata->buffer_size = 0x80;  /*FIFO size is 128*/
  

• }

I would add spaces around these comments (after /* and before */).