On Thu, Dec 4, 2008 at 7:51 PM, Daniel Mack daniel@caiaq.org wrote:
Some minor updates for sound/soc/codecs/tlv320aic3x.c:
- removed "DAC" from name for "Mono playback switch", "HP playback
switch" and "HPCOM playback switch". The registers used in the macro don't have anything to do with the DAC but mute the whole output, hence the names were misleading.
Hi Daniel!
This is true, I found it also sometime ago that muting those DAC playback switches muted the whole output even there were bypass paths active but didn't find time to look it any deeper yet.
I think by quick look, that your fix changing "x DAC Playback Switch" to "x Playback Switch" separating it thus from "x DAC Playback Volume" is likely correct one.
I'll try to look this tomorrow or monday and give you a note. Generally I would say, this should go as a separate fix patch and changes below into another.
- split "Line Playback Switch" into "LineL Playback Switch" and "LineR
Playback Switch"
- split "Line PGA Bypass Playback Volume" into "LineL Left PGA Bypass
Playback Volume" and "LineR Right PGA Bypass Playback Volume"
- split "Line Line2 Bypass Playback Volume" into "LineL Line2 Bypass
Playback Volume" and "LineR Line2 Bypass Playback Volume"
- Added "HP Right PGA Bypass Playback Volume"
Jarkko