Re: [PATCH v2 02/25] ALSA: pcm: Add copy ops with iov_iter

2 Sep 2023


      On Sat, 02 Sep 2023 07:30:44 +0200,
Al Viro wrote:
...
On Tue, Aug 15, 2023 at 09:01:13PM +0200, Takashi Iwai wrote:
...

if (copy_from_user(get_dma_ptr(substream->runtime, channel, hwoff),
	   (void __user *)buf, bytes))


if (!copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff),
	    bytes, iter))


The former is "if not everything got copied", the latter - "if nothing got
copied"; the same goes for other places like that.
Thanks, yes, this should be
    if (copy_from_iter(...) != bytes)
Other places have been already corrected in v2 patchset, but this
place was overseen.  Will fix it.
Takashi