27 Sep
2014
27 Sep
'14
12:18 p.m.
On Fri, Sep 26, 2014 at 01:31:06PM -0700, Anatol Pomozov wrote:
Analog Devices SSM4567 is a boost class-D audio amplifier.
Applied, but don't send patches in reply to existing threads especially if you don't include a version tag in the header. This was very nearly deleted unread. One thing to look at incrementally:
ret = regmap_update_bits(ssm4567->regmap,
SSM4567_REG_POWER_CTRL,
SSM4567_POWER_SPWDN, 0x00);
regcache_sync(ssm4567->regmap);
This checks the return value of _update_bits() but not _sync() - make your mind up please! I'd also split the _set_power() function into two, there is much more conditional code for the two cases than common code in there.