On Mon, Aug 14, 2023 at 11:01 AM Brady Norander bradynorander@gmail.com wrote:
On Mon, Aug 14, 2023 at 08:54:15AM -0500, Pierre-Louis Bossart wrote:
same here, I don't think we can blindly add quirks.
One might argue it doesn't hurt but not all SKUs are supported by Chrome.
Fair enough. I wasn't sure which SKUs were used in Chrome platforms and which ones weren't so I figured it would be safer to include all of them than miss some that are needed. I can resend the patch without the quirk for the PX SKUs.
FTR we carry a .conf which has the following config which is probably why we don't see this issue. I understand this behaviour for dual supported legacy platforms but it is indeed weird to see on SOF only supported platforms.
# Use the SOF driver for PCI_DEVICE(0x8086, 0x9dc8) instead of snd_hda_intel options snd_intel_sdw_acpi sdw_link_mask=0x5 options snd_intel_dspcfg dsp_driver=3 options snd_sof_intel_hda_common always_enable_dmi_l1=1 blacklist snd_hda_intel