Re: [PATCH v3] ASoC: amd: acp: Initialize list to store acp_stream during pcm_open

28 Jul 2022


      On Thu, Jul 28, 2022 at 06:10:50PM +0530, Venkata Prasad Potturu wrote:
...
@@ -104,14 +105,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));

for (i = 0; i < ACP_MAX_STREAM; i++) {
stream = adata->stream[i];




spin_lock_irqsave(&adata->acp_lock, flags);
list_for_each_entry(stream, &adata->stream_list, list) {

If we're already in an interrupt handler here (presumably not a threaded
one) why are we using irqsave?

    

Mark Brown