On Thu, 11 Mar 2021 15:22:22 +0100, Andy Shevchenko wrote:
On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai tiwai@suse.de wrote:
On Thu, 11 Mar 2021 14:27:41 +0100, Andy Shevchenko wrote:
Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance. No functional change implied.
I'd love to apply this kind of cleanups (and I do sometimes partially), but practically seen, this may make the stable backporting significantly harder because many quirk patches are backported to the very old LTS kernels. So, unless any specific reason (e.g. some entries doubled or wrongly applied) is given, I'd avoid this full plastic surgery.
Btw, can we apply the hunks that are against the lines under #if 0? At least it will reduce the chaos rate in the file w/o worrying that people will add entries there to backport.
If the #if-0-block causes a problem, we can drop it, too. There are two big ones, and those have been disabled for almost a decade already, so it's quite safe to drop them.
Takashi