At Mon, 11 Aug 2014 10:06:48 +0200, Takashi Iwai wrote:
At Sun, 10 Aug 2014 15:38:42 +0200, Jurgen Kramer wrote:
On Sun, 2014-08-10 at 13:44 +0200, Takashi Iwai wrote:
At Sat, 9 Aug 2014 12:09:21 +0200, Jurgen Kramer wrote:
Support for DSD sample formats has been added a while ago. This patch makes those sample formats beter usable from userland (e.g. aplay).
include/sound/asound.h | 4 +++- src/pcm/pcm_misc.c | 4 ++++
The new definitions are still missing in include/pcm.h? include/sound/asound.h is a copy from the kernel, and the user-land API is defined rather in include/pcm.h.
OK, the updates to alsa-lib pcm_misc.c are still valid but do not compile without my proposed update to include/sound/asound.h
Yes, we need to change both include/pcm.h and include/sound/asound.h. In your patch, the necessary change in include/pcm.h is missing, and that's what I suggested.
I overlooked that include/pcm.h had already the definition of DTD things. So now the patch was applied as is with a couple of more additional fixes.
Takashi