Re: [alsa-devel] [PATCH_V2 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

On Monday 26 January 2015 13:15:36 Zubair Lutfullah Kakakhel wrote:

+Required properties: +- compatible : "ingenic,jz4740-i2s" +- reg : I2S registers location and length +- clocks : AIC and I2S PLL clock specifiers. +- clock-names: "aic" and "i2s"

+Example:

+i2s: i2s@10020000 {

•   compatible = "ingenic,jz4740-i2s";
  

•   reg = <0x10020000 0x94>;
  

•   clocks = <&cgu JZ4740_CLK_AIC>, <&cgu JZ4740_CLK_I2SPLL>;
  

•   clock-names = "aic", "i2s";
  

•   dmas = <&dma 2>, <&dma 3>;
  

•   dma-names = "tx", "rx";
  

Thanks for adding the dma entries to the example. Unfortunately you have missed adding them to the list of required properties, so please add those as well.

Arnd