Hi Mark, Pierre,
On 30/09/2021 23:24, Pierre-Louis Bossart wrote:
On 9/28/21 10:10 AM, Mark Brown wrote:
On Tue, Sep 28, 2021 at 11:22:48AM +0300, Peter Ujfalusi wrote:
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
The work-around enabled in hda-stream.c is only required on earlier versions of SOCs/PCH (Skylake, KabyLake, ApolloLake, GeminiLake). Before setting the format on the host DMA, it is required to couple the host and link DMA - which as a consequence shall use the same format.
This breaks the build for me:
/mnt/kernel/sound/soc/sof/intel/hda-stream.c: In function 'hda_dsp_stream_hw_params': /mnt/kernel/sound/soc/sof/intel/hda-stream.c:436:42: error: implicit declaration of function 'get_chip_info'; did you mean 'get_group_info'? [-Werror=implicit-function-declaration]
Sorry about that.
I'm going to script this from now.
It was sort of therapeutic meditation type of flow:
one slip of coffee find a patch / feature series git checkout -b to_upstream/<topic> <current_upstream_base> git cherry-pick <hash from sof-dev-rebase> if (fail) goto drop_patch; scripts/checkpatch.pl --strict -g HEAD if (fail) correct it(); compile (x64/aarch64, sparse for both) - this I have scripted if (fail) goto drop_patch; boot test if (fail) goto drop_patch; format-patch && send
fail: drop patch or series and try to find another one.
I must have skipped the compile phase.
Ack, we're missing a dependency.
Peter, this function was moved to shim.h with Ranjani's patch "ASoC: SOF: Intel: hda: expose get_chip_info()"
That patch was added in the SOF multi-core series.
Yes, it is and it does not apply without the dynamic pipelines and possibly have dependency on other patches from the muticore support for the dynamic-pipelines.
Sorry for the trouble, I'll start with a coffee then the script.