-----Original Message----- From: Ravulapati Vishnu vardhan rao Vishnuvardhanrao.Ravulapati@amd.com Sent: Monday, September 30, 2019 8:58 PM Cc: Deucher, Alexander Alexander.Deucher@amd.com; RAVULAPATI, VISHNU VARDHAN RAO Vishnuvardhanrao.Ravulapati@amd.com; Liam Girdwood lgirdwood@gmail.com; Mark Brown broonie@kernel.org; Jaroslav Kysela perex@perex.cz; Takashi Iwai tiwai@suse.com; Mukunda, Vijendar Vijendar.Mukunda@amd.com; Maruthi Srinivas Bayyavarapu Maruthi.Bayyavarapu@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; Colin Ian King colin.king@canonical.com; Dan Carpenter dan.carpenter@oracle.com; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... alsa-devel@alsa-project.org; open list linux-kernel@vger.kernel.org Subject: [PATCH 1/7] ASoC: amd: No need PCI-MSI interrupts
ACP-PCI controller driver does not depends msi interrupts. So removed msi related pci functions which have no use and does not impact on existing functionality.
In general, however, aren't MSIs preferred to legacy interrupts? Doesn't the driver have to opt into MSI support? As such, won't removing this code effectively disable MSI support?
Alex
Signed-off-by: Ravulapati Vishnu vardhan rao
Vishnuvardhanrao.Ravulapati@amd.com
sound/soc/amd/raven/pci-acp3x.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci- acp3x.c index facec24..8f6bf00 100644 --- a/sound/soc/amd/raven/pci-acp3x.c +++ b/sound/soc/amd/raven/pci-acp3x.c @@ -46,14 +46,7 @@ static int snd_acp3x_probe(struct pci_dev *pci, goto release_regions; }
- /* check for msi interrupt support */
- ret = pci_enable_msi(pci);
- if (ret)
/* msi is not enabled */irqflags = IRQF_SHARED;- else
/* msi is enabled */irqflags = 0;
irqflags = 0;
addr = pci_resource_start(pci, 0); adata->acp3x_base = ioremap(addr, pci_resource_len(pci, 0)); @@ -
112,7 +105,6 @@ static int snd_acp3x_probe(struct pci_dev *pci, return 0;
unmap_mmio:
- pci_disable_msi(pci); iounmap(adata->acp3x_base);
release_regions: pci_release_regions(pci); @@ -129,7 +121,6 @@ static void snd_acp3x_remove(struct pci_dev *pci) platform_device_unregister(adata->pdev); iounmap(adata->acp3x_base);
- pci_disable_msi(pci); pci_release_regions(pci); pci_disable_device(pci);
}
2.7.4