Re: [alsa-devel] [PATCH] ALSA: ctl: change return value in compatibility layer so that it's the same value in core implementation

On Thu, 17 Mar 2016 13:14:36 +0100, Takashi Sakamoto wrote:

In control compatibility layer, when no elements are found by ELEM_READ/ELEM_WRITE ioctl commands, ENXIO is returned. On the other hand, in core implementation, ENOENT is returned. This is not good for ALSA ctl applications.

This commit changes the return value from the compatibility layer so that the same value is returned.

Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp

Applied, thanks.

Takashi

---

sound/core/control_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/control_compat.c b/sound/core/control_compat.c index 0608f21..1fa7076 100644 --- a/sound/core/control_compat.c +++ b/sound/core/control_compat.c @@ -196,7 +196,7 @@ static int get_ctl_type(struct snd_card *card, struct snd_ctl_elem_id *id, kctl = snd_ctl_find_id(card, id); if (! kctl) { up_read(&card->controls_rwsem);

• return -ENXIO;
  

• return -ENOENT;
  

  } info = kzalloc(sizeof(*info), GFP_KERNEL); if (info == NULL) {

-- 2.7.0