Re: [alsa-devel] [PATCH] ASoC: codecs: PCM1789: include gpio/consumer.h

On Wed, May 30, 2018 at 11:53 PM, Arnd Bergmann arnd@arndb.de wrote:

When CONFIG_GPIOLIB is disabled, this codec fails to build because gpio/consumer.h is not included implicitly.

sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init': sound/soc/codecs/pcm1789.c:247:19: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration] pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); ^~~~~~~~~~~~~~~~~~~~~~~

Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789") Signed-off-by: Arnd Bergmann arnd@arndb.de

Reviewed-by: Linus Walleij linus.walleij@linaro.org

Yours, Linus Walleij