Re: [alsa-devel] [PATCH 4/5] ASoC: Intel: bytcr_rt5651: filter codec name

On Fri, 2017-09-08 at 12:43 -0500, Pierre-Louis Bossart wrote:

Use same fix as other codecs to work around BIOS/ACPI issues

{ int ret_val = 0;

• struct sst_acpi_mach *mach;
• const char *i2c_name = NULL;
• int i;
• int dai_index; struct byt_rt5651_private *priv;

I would rather put variables in reversed xmas tree order or close to it.

+

• /* fixup codec name based on HID */
• i2c_name = sst_acpi_find_name_from_hid(mach->id);

• if (i2c_name != NULL) {

if (i2c_name) { ?